Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Comments

feat: add CLI support for different hash func and type#748

Merged
daviddias merged 1 commit intomasterfrom
feat/update-block-api
Jan 31, 2017
Merged

feat: add CLI support for different hash func and type#748
daviddias merged 1 commit intomasterfrom
feat/update-block-api

Conversation

@daviddias
Copy link
Member

@daviddias daviddias commented Jan 31, 2017

@kumavis I've imported the changes you made on the DAG API PR -- #636 -- to here, but getting this error:

  1) cli --all block with daemon off (requiring js-ipfs core directly) put with flags, format and mhtype:

      AssertionError: expected 'cZxfGwVjp1wDnUowKQ5sR6zEQubxB8Dys2dMZ4t8a3dnse' to deeply equal 'z43AaGF23fmvRnDP56Ub9WcJCfzSfqtmzNCCvmz5eudT8dtdCDS'
      + expected - actual

      -cZxfGwVjp1wDnUowKQ5sR6zEQubxB8Dys2dMZ4t8a3dnse
      +z43AaGF23fmvRnDP56Ub9WcJCfzSfqtmzNCCvmz5eudT8dtdCDS

      at ipfs.then (test/cli/test-block.js:21:24)
      at process._tickDomainCallback (internal/process/next_tick.js:129:7)

Was this working for you before?

@daviddias daviddias added the status/in-progress In progress label Jan 31, 2017
@kumavis
Copy link
Contributor

kumavis commented Jan 31, 2017 •
edited
Loading

yeah was working before -- not sure whats wrong here

@kumavis
Copy link
Contributor

kumavis commented Jan 31, 2017

@diasdavid the hash matches the eth-block test z43AaGF23fmvRnDP56Ub9WcJCfzSfqtmzNCCvmz5eudT8dtdCDS

but the test message/label doesnt match?

@daviddias daviddias force-pushed the feat/update-block-api branch from fa6053c to 2074e9b Compare January 31, 2017 18:54
@daviddias
Copy link
Member Author

daviddias commented Jan 31, 2017

just fixed it, the if clause was wrong because when I migrated, I kept the option to do CIDv0 too and introduced a bug, now it is good :)

@daviddias daviddias requested a review from kumavis January 31, 2017 18:55
@daviddias daviddias force-pushed the feat/update-block-api branch from 2074e9b to 5d17711 Compare January 31, 2017 19:07
@daviddias daviddias force-pushed the feat/update-block-api branch from 5d17711 to d9833f8 Compare January 31, 2017 19:27
@daviddias daviddias merged commit a6c522f into master Jan 31, 2017
@daviddias daviddias deleted the feat/update-block-api branch January 31, 2017 19:44
@daviddias daviddias removed the status/in-progress In progress label Jan 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kumavis kumavis kumavis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daviddias @kumavis